fix panic on minimized window while using with_render_sky_to_texture()#5
Open
oerli wants to merge 1 commit intoTanTanDev:mainfrom
Open
fix panic on minimized window while using with_render_sky_to_texture()#5oerli wants to merge 1 commit intoTanTanDev:mainfrom
oerli wants to merge 1 commit intoTanTanDev:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
while using .with_render_sky_to_texture(), minimizing the window will result in a panic:
wgpu error: Validation Error
Caused by:
In Device::create_texture
Dimension X is zero
following fix skips resize of image texture if window size is 0 x 0 (when the window gets minimized).
and it also sets minimum for 1.0 x 1.0 at startup (this would only be necessary if bevy would ever allow to start minimized).
i tested it with my project and it stopped panic on minimizing.